Fix integer overflow for remaining index stats

[oksanay]

Description

Changed data types in QueryCacheStats object to be longs
Example of the data which is having problem when datatypes are integers
"query_cache" : {
"memory_size_in_bytes" : 892496036,
"total_count" : 8757938874,
"hit_count" : 347443703,
"miss_count" : 8410495171,
"cache_size" : 18507,
"cache_count" : 169300,
"evictions" : 150793
}

Issues Resolved

#959

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

Look at the failure log, it fails on :java-client:spotlessJavaCheck. It's just a formatting problem, to fix run ./gradlew :java-client:spotlessApply.

[dblock]

Looks good!

[dblock]

CHANGELOG needs fixing.

[dblock]

There's a typo in opensearch-java here, so the link checker caught it and that's why the build failed.

[dblock]

This link is still incorrect, #254 is the correct one.

[dblock]

One more.

[oksanay]

@dblock I pushed change to test-unit.yml

[dblock]

@oksanay First, thank you for fixing this! Let's get this passing and merged.

Open an issue like #949 for a release, referencing this issue, we can do this quickly.

[oksanay]

@dblock now all checks passed

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-960-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f0797da1ac1715884d7f105b6507012a53a9b374
# Push it to GitHub
git push --set-upstream origin backport/backport-960-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-960-to-2.x.

[dblock]

@oksanay Looks like this will need a manual backport to the 2.x branch, please? I believe we release from that (@VachaShah can correct me if I am wrong).

[VachaShah]

Thats right @dblock! We release a new minor or patch version from the 2.x branch.

[oksanay]

@dblock and @VachaShah so do I need to open the issue for the release or not?

[oksanay]

and do I need to run this manual backport stuff?

[dblock]

@oksanay Yes. We have an automated workflow that works most of the time, but it failed here because it caused a conflict that needs to be manually resolved.

[dblock]

@dblock and @VachaShah so do I need to open the issue for the release or not?

Yes, please.

You have to do both the backport and open a release ticket if you need a release faster than "whenever".

[oksanay]

It should be 2.11.1, right?

[oksanay]

@dblock @VachaShah ^ ?

[dblock]

This is a bug fix on 2.10.1, so it should be 2.10.2.

We will also need to move the CHANGELOG entry accordingly when we release.

[oksanay]

@dblock This command is failing with any combination of 2,10
git worktree add ../.worktrees/backport-2.10.1 2.10.1
I tried 2.10.1, 2.10.2 2.10. Sorry I am so noisy

[dblock]

@oksanay The easiest way is to just re-apply your commit to the 2.x branch.

In your fork:

git checkout 2.x
git pull upstream 2.x
git checkout -b 2.x-backport-960
git cherry-pick f0797da1ac1715884d7f105b6507012a53a9b374
# fix conflicts, commit
git push origin 2.x-backport-960
# make PR into 2.x

If you're struggling I can do it quickly.

[oksanay]

@dblock YES, please! I have a deadline today with my own stuff and I AM struggling

[dblock]

#965

[dblock]

I opened a release proposal ticket in #966.

[oksanay]

Thank you so much!!!!