[Backport 2.x] [BUG] Generic HTTP Actions in Java Client does not work with AwsSdk2Transport #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
reta
approved these changes
May 14, 2024
|
|
…ransport (#978) * [BUG] Generic HTTP Actions in Java Client does not work with AwsSdk2Transport Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit b8e0dad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
force-pushed
the
backport/backport-978-to-2.x
branch
from
23c4536
to
6077918
Compare
reta
reviewed
May 14, 2024
| @@ -370,7 +370,6 @@ private <ResponseT> ResponseT decodeResponse( | |||
| InputStream content = null; | |||
| if (entity != null) { | |||
| // We may have to replay it. | |||
| entity = new BufferedHttpEntity(entity); | |||
There was a problem hiding this comment.
Removing unnecessary buffering since response is converted to bytes now, always (https://github.com/opensearch-project/opensearch-java/pull/984/files#diff-0eec44b1849b65152d79b3673d9ebb77442080c306919c5e931506a6aa0a31f0R98)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b8e0dad from #978.