Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helpers.d.ts #396

Closed
wants to merge 1 commit into from
Closed

Conversation

develerltd
Copy link

@develerltd develerltd commented Feb 21, 2023

Description

change type of datasource to

datasource: TDocument[] | Buffer | ReadableStream | AsyncIterable<TDocument>;

Issues Resolved

Closes: #395

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darren Cresswell darren@develer.co.uk

change type of datasource to 
```
datasource: TDocument[] | Buffer | ReadableStream | AsyncIterable<TDocument>;
```
@harshavamsi
Copy link
Collaborator

@develerltd can you amend you commit with -s so that DCO can pass.

@nhtruong
Copy link
Collaborator

@develerltd can you update the changelog as well? Thank you!

@develerltd
Copy link
Author

sorry just got back to this. I made the commit directly through github, do i need to pull the repo down and re-create in order to sign it?

@dblock
Copy link
Member

dblock commented Mar 8, 2023

sorry just got back to this. I made the commit directly through github, do i need to pull the repo down and re-create in order to sign it?

I am afraid you will.

@nhtruong
Copy link
Collaborator

@develerltd are you still interested in solving this? You're so close to the finish line :)

@nhtruong nhtruong closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type for datasource AsyncIterator (should be AsyncIterable)
4 participants