fix typo in msearch guide (index -> indices) #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It causes "TypeError: client.index.refresh is not a function" when trying to run the sample codes in msearch.md. Signed-off-by: Wei Sun <wei.sun10@microfocus.com>
weisun10
requested review from
ananzh,
kavilla,
dblock,
VachaShah,
nhtruong,
harshavamsi and
timursaurus
as code owners
dblock
approved these changes
Mar 26, 2024
|
Can you please double check that the code in the guide matches the working sample in https://github.com/opensearch-project/opensearch-js/blob/main/samples/msearch.js? |
@dblock yes. The code in guide matches the msearch.js sample. It's a bit simpler but does similar client.bulk, client.indices.refresh, client.msearch and client.indices.delete. |
dblock
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It causes "TypeError: client.index.refresh is not a function" when trying to run the sample codes in msearch.md.
Description
There is a typo in msearch.md.
The "client.index.refresh" in "await client.index.refresh({ index: 'movies' });" should be "client.indices.refresh" instead.
Issues Resolved
Fix a typo in msearch.md.
Check List
yarn run lintdoesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.