-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Generated API - 3.0.0 #864
Conversation
Let's branch 2.x before we merge this in order to have patch releases? |
eec46f0
to
d43db2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good.
I don't know how much we care, but a very large amount of files are changed for a 1-liner in the license header. Adding an extra *
would reduce this PR by half I imagine.
Another though on the camelcase/snake case. Having to update all code from one method to the other is going to be a barrier for users even though it's mostly a trivial change. Would it make sense to consider also generating wrapper methods with the old names and marking them deprecated for another major version iteration? Or to generate a compatibility layer that can be optionally included?
c4f510b
to
447b094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I tried to go through all the changes, made some suggestions in text.
I think after this is merged we should get another beta off main bofore releasing a final version. The final should be basically like the previous beta.
I agree. There will be 2 follow-up PRs after this one:
|
Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Merge at will. The fact that samples don't have any changes in them is very encouraging.
Changed
Removed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.