Add required header for SigV4 signing #119
Conversation
harshavamsi
force-pushed
the
serverlessSigV4
branch
2 times, most recently
from
feba660
to
6460203
Compare
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
serverlessSigV4
branch
from
6460203
to
01a00d0
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #119 +/- ##
============================================
+ Coverage 23.89% 23.90% +0.01%
Complexity 1936 1936
============================================
Files 245 245
Lines 6856 6857 +1
============================================
+ Hits 1638 1639 +1
Misses 5218 5218
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@dblock we've already added tests/changelog/user_guide in a prior PR. This just fixes an issue as part of that. |
I don't think I agree ;)
I'll stay corrected on 2) and 3) which were added in #117, but you want to add this PR to the list still in CHANGELOG. |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
serverlessSigV4
branch
from
90e3e8b
to
0125698
Compare
| @@ -98,6 +100,7 @@ public function testSignsWithProvidedCredentialsAndService() | |||
| $toWrap = function (array $ringRequest) { | |||
| $this->assertArrayHasKey('X-Amz-Security-Token', $ringRequest['headers']); | |||
| $this->assertSame('baz', $ringRequest['headers']['X-Amz-Security-Token'][0]); | |||
| $this->assertArrayHasKey('x-amz-content-sha256', $ringRequest['headers']); | |||
There was a problem hiding this comment.
You could verify the actual value, SHA is always the same for the same body.
|
@harshavamsi thank you, using your fork make us able to user Amazon OpensSarch Serverless 🎉 |
Description
Fixes missing header for Amazon OpenSearch Serverless
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.