fix: remove trailing slash on given host #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
force-pushed
the
trim-slash-on-path
branch
from
81ab1f7
to
f240b93
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #140 +/- ##
============================================
- Coverage 23.91% 23.91% -0.01%
+ Complexity 1935 1932 -3
============================================
Files 245 245
Lines 6848 6845 -3
============================================
- Hits 1638 1637 -1
+ Misses 5210 5208 -2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shyim
force-pushed
the
trim-slash-on-path
branch
from
f240b93
to
f85eb85
Compare
Signed-off-by: GitHub <noreply@github.com>
shyim
force-pushed
the
trim-slash-on-path
branch
from
f85eb85
to
7525b5c
Compare
dblock
approved these changes
Mar 28, 2023
harshavamsi
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove trailing slash on given hosts
Issues Resolved
Fixes #138
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.