Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in ClientBuilder where basic authentication is overridden by connection params #160

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

CSalih
Copy link
Contributor

@CSalih CSalih commented Jul 6, 2023

Description

This fixes a bug in ClientBuilder where basic authentication is overridden when first basic authentication then connection params is set.

Issues Resolved

Fixes #159

Signed-off-by: Salih Candir <salih@live.at>
…n by connection params

Signed-off-by: Salih Candir <salih@live.at>
Signed-off-by: Salih Candir <salih@live.at>
Signed-off-by: Salih Candir <salih@live.at>
tests/ClientBuilderTest.php Outdated Show resolved Hide resolved
…request

Signed-off-by: Salih Candir <salih@live.at>
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #160 (ee9c261) into main (8b6cdbc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #160      +/-   ##
============================================
+ Coverage     24.14%   24.16%   +0.02%     
- Complexity     1937     1938       +1     
============================================
  Files           246      246              
  Lines          6863     6865       +2     
============================================
+ Hits           1657     1659       +2     
  Misses         5206     5206              
Impacted Files Coverage Δ
src/OpenSearch/ClientBuilder.php 74.42% <100.00%> (+0.19%) ⬆️

@CSalih CSalih requested a review from dblock July 8, 2023 13:04
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough. I would have stored username and password as is, but this is internal implementation details :)

@shyim shyim merged commit 5c5453c into opensearch-project:main Jul 12, 2023
@shyim
Copy link
Collaborator

shyim commented Jul 12, 2023

Thanks for your work on this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ClientBuilder::fromConfig overrides basic authentication
3 participants