Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction for BWC tests on distribution level #196

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Jan 23, 2023

Signed-off-by: Zelin Hao zelinhao@amazon.com

Description

Adding onboarding instruction and documents for BWC tests on distribution level for plugins.

Issues Resolved

Part of opensearch-project/opensearch-build#2870

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
TESTING.md Outdated
@@ -102,7 +102,7 @@ Each plugin can test various functionalities in their bwc tests and add more sce

The BWC tests running on distribution level are using the same framework from OpenSearch. The test cluster is spin up with the `latest` distribution bundle of provided version exclusively when the project is initialized with property `-PcustomDistributionDownloadType=bundle`.

The distribution bundle will be obtained with this format URL: https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/__REPLACE_VERSION__/latest/linux/x64/tar/dist/opensearch/opensearch-__REPLACE_VERSION__-linux-x64.tar.gz.
The distribution bundle will be obtained with this format URL: `https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/__REPLACE_VERSION__/latest/linux/x64/tar/dist/opensearch/opensearch-__REPLACE_VERSION__-linux-x64.tar.gz`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example would be nice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saratvemulapalli Updated with the example for v1.3.2. Thanks.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh zelinh force-pushed the add-doc-bwc-bundle branch from b51551b to ec81149 Compare January 23, 2023 23:56
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
dblock
dblock previously requested changes Jan 26, 2023
@@ -98,6 +98,17 @@ See [anomaly-detection#158](https://github.com/opensearch-project/anomaly-detect

Each plugin can test various functionalities in their bwc tests and add more scenarios if needed.

#### BWC tests on distribution bundle level
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOC needs updating, please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dblock Thanks dB. Just updated the table. Thanks!

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh
Copy link
Member Author

zelinh commented Jan 30, 2023

@dblock @saratvemulapalli Could you help review another times. Need one more approval. Thanks.

@zelinh zelinh dismissed dblock’s stale review February 2, 2023 18:34

Dismissing blocker.

@zelinh
Copy link
Member Author

zelinh commented Feb 2, 2023

Merging this for now.

@zelinh zelinh merged commit 45044b6 into opensearch-project:main Feb 2, 2023
@zelinh zelinh deleted the add-doc-bwc-bundle branch February 2, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants