-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate meta file #219
Conversation
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
The intent of the top-level meta was to have a sum of all plugins, especially that there used to be duplicates where an OpenSearch plugin and a Dashboards plugin were in the same repo. |
Thanks @dblock, its not always updated and updating at two places might cause missing at one place, this plugin list is used during the release issue creation (and for other automations). Removed the top Another point I have noticed is sometimes the plugin list has the plugin that is not yet ready for a release (ex |
Yeah even for compatibility check which is using plugins/.meta file, |
The real problem is that multiple versions of OpenSearch have different plugins. So using this list from an upstream is never going to work - I suggest using the previously released version manifest in opensearch-build for your original purpose of getting the "list of plugins". |
Ya this |
@prudhvigodithi @dblock But manifest might not be the source of truth as plugins are added incrementally. Does it make sense to have 1.x, 2,x and 3.x default manifests with all plugins in the list? |
What do you think about a solution where the list of plugins always exists in the build manifest, opensearch-project/opensearch-build#3707? |
This also makes sense. Would it be too much confusing? Placeholder / non-placeholder? |
We can discuss it in that proposal. |
Description
Remove duplicate
.meta
file from the root folder as the meta files for OS is underplugins/.meta
and OSD is underdashboards-plugins/.meta
Fix few broken links for the
linkchecker
to pass.Issues Resolved
Part of opensearch-project/opensearch-build#3616 and opensearch-project/.github#167
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.