Remove include_type_name parameter from APIs #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
dblock
approved these changes
Apr 20, 2022
saratvemulapalli
approved these changes
Apr 20, 2022
| @query_params( | ||
| "include_type_name", "master_timeout", "timeout", "wait_for_active_shards" | ||
| ) | ||
| @query_params("master_timeout", "timeout", "wait_for_active_shards") |
There was a problem hiding this comment.
While we are working on this, is there a plan to work on inclusive naming for clients?
I've opened up an issue as I didn't see one: opensearch-project/opensearch-clients#16
There was a problem hiding this comment.
The inclusive naming changes will be done once the breaking changes are in for the clients. I will add a reference to this issue in the original meta issue.
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vacha Shah vachshah@amazon.com
Description
Remove
include_type_nameparameter from API endpoints as part of breaking changes for 2.0.Issues Resolved
Part of #145
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.