Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev guide, lock aiohttp to a version that works. #828

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 25, 2024

Description

Update developer guide with test setup instructions using OpenSearch 2.12+.

The two failing tests.

FAILED test_opensearchpy/test_async/test_http_connection.py::TestAsyncHttpConnection::test_basicauth_in_request_session - TypeError: 'coroutine' object is not iterable
FAILED test_opensearchpy/test_async/test_http_connection.py::TestAsyncHttpConnection::test_callable_in_request_session - TypeError: 'coroutine' object is not iterable

The headers in warning_headers = response.headers.getall("warning", ()) changed between aiohttp 3.9 and 3.10 from () to <coroutine object AsyncMockMixin._execute_mock_call at 0x103732ff0>, not sure why.

For now I opened aio-libs/aiohttp#9297 and locked the version to <= 3.10.5.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…2.12+.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock added the skip-changelog Skips changelog verifier label Sep 25, 2024
@dblock dblock force-pushed the fix-tests branch 3 times, most recently from 2653241 to 49c3d31 Compare September 25, 2024 20:42
Signed-off-by: dblock <dblock@amazon.com>
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.34%. Comparing base (ba715b9) to head (863ff9b).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   71.95%   70.34%   -1.61%     
==========================================
  Files          91      113      +22     
  Lines        8001     8875     +874     
==========================================
+ Hits         5757     6243     +486     
- Misses       2244     2632     +388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock marked this pull request as ready for review September 25, 2024 21:24
@dblock dblock changed the title Update developer guide with test setup instructions using OpenSearch 2.12+. Update dev guide, lock aiohttp to a version that works. Sep 25, 2024
Signed-off-by: dblock <dblock@amazon.com>
@saimedhi saimedhi merged commit 45d8172 into opensearch-project:main Sep 25, 2024
32 of 33 checks passed
@dblock dblock deleted the fix-tests branch September 25, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants