Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle integration tests. #856

Closed

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 27, 2024

Description

For #848.

Adds samples and integration tests for the lifecycle of an index and document with a unicode name and id.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock marked this pull request as ready for review November 27, 2024 16:59
@dblock dblock added the skip-changelog Skips changelog verifier label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (ba715b9) to head (2503919).
Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
- Coverage   71.95%   70.31%   -1.64%     
==========================================
  Files          91      125      +34     
  Lines        8001     9299    +1298     
==========================================
+ Hits         5757     6539     +782     
- Misses       2244     2760     +516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: dblock <dblock@amazon.com>
@dblock
Copy link
Member Author

dblock commented Nov 27, 2024

Included in #848.

@dblock dblock closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant