Removed RubyGems MFA Opt-in clause #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhtruong
requested review from
VijayanB,
jayeshathila,
robsears,
vamshin,
dblock,
VachaShah and
harshavamsi
as code owners
dblock
reviewed
Sep 15, 2023
opensearch-ruby.gemspec
Outdated
| @@ -66,5 +65,5 @@ Gem::Specification.new do |s| | |||
| s.required_ruby_version = '>= 2.5' | |||
|
|
|||
| s.add_dependency 'faraday', '>= 1.0', '< 3' | |||
| s.add_dependency 'multi_json' | |||
| s.add_dependency 'multi_json', '~> 1.0' | |||
There was a problem hiding this comment.
This is suspicious, did you mean >= 1.0? They are at 1.15. There's no reason why a 2.x won't work when that comes out.
There was a problem hiding this comment.
It was intentional because I didn't want 2.x breaking changes to affect us. But, I guess then some of our specs would fail as a result as we can handle this issue then. Going to update it per your suggestion so that users can use 2.x in their apps if they want to.
There was a problem hiding this comment.
Yep, generally you lock down semver a minimum of what's known at the time of writing. Otherwise you end up with an impossible to resolve matrix for no reason.
dblock
previously approved these changes
Sep 15, 2023
Signed-off-by: Theo Truong <theotr@amazon.com>
nhtruong
force-pushed
the
remove_rubygems_mfa
branch
from
29ca6f5 to
fe61d8c
Compare
dblock
approved these changes
Sep 15, 2023
VachaShah
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multi_jsonauthorsandemailfields to be in line with other OpenSearch gems.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.