-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds inclusive naming #99
Conversation
@tlfeng could you take a stab at this review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work equally well against multiple major versions of OpenSearch 1.x, 2.x and 3.x? If I am using an older version against OpenSearch 2.x can I upgrade to this client without rewriting any code? Then can I just start calling the new APIs to remove deprecations?
@Yury-Fridlyand you did this recently for .NET client - care to take a look at this? |
I'm noob in ruby, but I'll do my best. opensearch-ruby/opensearch-api/lib/opensearch/api/utils.rb Lines 99 to 107 in bc935d0
AFAIK, _type support was remoted in OpenSearch, see opensearch-project/OpenSearch#1940.Please, check this comment, and it is outdated, update it and let me know. There are few more comments like this, perhaps they should be updated too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to make sure we're working on integration tests that run against both OpenSearch 1.x and 2.x.
Fix CI? Looks like the code needs to be server-version aware.
Yes, we've only deprecated the master nomenclature without removing them and added new endpoints for |
@nhtruong would you be able to review this? If you review, I'll approve. |
f5d05bb
to
cc4beec
Compare
@harshavamsi Can you rebase with main? This would need a CHANGELOG after the rebase. |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
cc4beec
to
ffbb0b1
Compare
aeb08b3
to
8edd88a
Compare
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Description
master
tocluster_manager
cluster_manager_timeout
while deprecatingmaster_timeout
cat/cluster_manager
API while deprecatingcat/master
Issues Resolved
Closes #72
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.