Change delete index API to logical delete #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
change-logical-delete
branch
from
9bd6fc6 to
11b8270
Compare
dai-chen
changed the title
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
requested review from
rupal-bq,
vmmusings,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
penghuo
approved these changes
Jan 19, 2024
Signed-off-by: Chen Dai <daichen@amazon.com>
Missed it. Updated user manual here: https://github.com/dai-chen/opensearch-spark/blob/change-logical-delete/docs/index.md#sql. Thanks! |
vmmusings
reviewed
Jan 19, 2024
| - **SHOW:** Display all Flint indexes in the specified catalog or source table. | ||
| - **DESCRIBE:** Retrieve detailed information about a Flint index. | ||
| - **DROP:** Delete a Flint index logically. This action stops the refreshing process and rules it out in query rewrite. | ||
| - **VACUUM:** Physically remove all data associated with a Flint index, including index metadata and data. This operation effectively cleans up and frees resources. |
There was a problem hiding this comment.
Just curious, is there any precedence for this work "VACCUM"
There was a problem hiding this comment.
you can find more details here: #189. This is mainly to fix the inconsistent behavior with SQL plugin on drop index statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up PR after #189 which changes the semantic of delete index API from physical to logical delete.
Issues Resolved
#104
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.