Fix index name with uppercase letter issue #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenSearch has restriction on index name and only allows lowercase letter. Because Flint index is not registered to Glue/Hive metastore, table name and index name given in create statement is encoded into OpenSearch index name.
Without the fix
SQL statement such as
CREATE SKIPPING INDEX ON myGlue.default.alb_logs
will fail due to capitalG
andflint_myGlue_default_alb_logs_skipping_index
index name generated.With the fix
For any API, do this lowercase conversion in low-level
FlintOpenSearchClient
since this is restriction in OpenSearch store.Documentation
Updated user manual with example and the limitation caused by this:
Refactoring
Potential refactor for
FlintOpenSearchClient
code in future:Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.