-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add color palettes in use across OpenSearch Dashboards #601
base: main
Are you sure you want to change the base?
Docs: Add color palettes in use across OpenSearch Dashboards #601
Conversation
…in visualizations Seeing these color palettes alongside the OUI color palettes and usage guidelines will help us consolidate and make visualizations more cohesive. Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"To avoid confusion, I may refactor this to be a cloned page that isn't linked from the navigation, so that it can be safely merged and deployed as a reference, but won't confuse users just looking for the current guidance."
I agree that this refactor would be the way to go and to use the resource for tracking and cohesion efforts. Thanks so much for putting this together!
@joshpalis Want to finish/close this? |
Description
and plugin visualizations.
Seeing these color palettes alongside the OUI color palettes and usage guidelines will help us consolidate and make visualizations more cohesive.
Includes link to various hard-coded color values and programmatic color generators.
Reviewers: It should be generally safe to ignore all the new files in the
src-docs/src/views/color_palette/osd_legacy_color_maps/
directory, except for the README - these were directly copied from other OpenSearch Dashboard projects for ease of collecting the palettes.Next steps
To avoid confusion, I may refactor this to be a cloned page that isn't linked from the navigation, so that it can be safely merged and deployed as a reference, but won't confuse users just looking for the current guidance.
I also need to investigate colors in other plugins such as Alerting, Anomaly Detection, and Maps.
Issues Resolved
fixes opensearch-project/OpenSearch-Dashboards#2586
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.