Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Failing PerformanceAnalyzerWebServerTest for Java17 #167

Closed
sruti1312 opened this issue Apr 15, 2022 · 1 comment
Closed

[BUG] Failing PerformanceAnalyzerWebServerTest for Java17 #167

sruti1312 opened this issue Apr 15, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sruti1312
Copy link
Contributor

What is the bug?
Failing PerformanceAnalyzerWebServerTest.testUnauthenticatedClientGetsRejected for Java17

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

What is the expected behavior?
A clear and concise description of what you expected to happen.

What is your host/environment?

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.

@sruti1312 sruti1312 added bug Something isn't working untriaged labels Apr 15, 2022
@kkhatua kkhatua added good first issue Good for newcomers and removed untriaged labels Oct 25, 2022
@Tjofil
Copy link
Contributor

Tjofil commented Jan 18, 2023

Did some investigation and the test is not failing due to client being able to authenticate and proceed successfully but due to Exception caught not being of SSLException type but SocketException ( Broken pipe ) where startSSLHandshake function is somewhere in the middle of the exception stack trace. This way we catch it the general Exception catch block and throw AssertionError failing the test.

I suspect the handshake implementation changed between versions so that server suddenly closes it's resources at some point and causes the client to read/write to a closed connection which tends to throw previously mentioned "Broken pipe" exception.

Something that backs this up:
https://bugs.openjdk.org/browse/JDK-8262053

I propose just including the SocketException as the possible cause of the auth fail assertions as the initialization of the server and the rest of the SSL setup seem standard to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants