-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and include unauthenticated user web server test #273
Fix and include unauthenticated user web server test #273
Conversation
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
============================================
+ Coverage 71.57% 71.92% +0.35%
- Complexity 2989 2997 +8
============================================
Files 380 380
Lines 18984 18984
Branches 1463 1463
============================================
+ Hits 13587 13654 +67
+ Misses 4803 4727 -76
- Partials 594 603 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find on the JDK version change causing the handshake behaviour. Thanks for the fix !
Accidentally closed. Reopening. |
Hey @kiranprakash154, I have no label assignment access on github to invoke the automatic bot backport PR, shall I do it by hand then ? And which branches beside 2.x should I backport to ? Edit: Did it manually 270 and 273 for 2.x |
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-273-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b74944a27a6028daacdb1951af941991d5f090c5
# Push it to GitHub
git push --set-upstream origin backport/backport-273-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
Signed-off-by: Filip Drobnjakovic drobnjakovicfilip@gmail.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Issue #167
Describe the solution you are proposing
Implementation of the proposed solution from the issue (#167) comment (by me). Please raise any additional concerns.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.