Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging for version increment automation #197

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Staging for version increment automation #197

merged 2 commits into from
Aug 1, 2022

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Jul 11, 2022

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
This is the staging PR for to execute workflows that auto raise the version increment PR's
Example: https://github.com/prudhvigodithi/performance-analyzer-rca/pull/2/files

Describe the solution you are proposing
Part of: opensearch-project/opensearch-build#1375
From solution: opensearch-project/opensearch-build#1375 (comment)
Related issue: #195

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
@prudhvigodithi prudhvigodithi requested a review from a team July 11, 2022 13:56
@prudhvigodithi prudhvigodithi changed the title Staging Version increment automation Staging for version increment automation Jul 11, 2022
@kkhatua kkhatua requested a review from sgup432 July 11, 2022 18:42
@sruti1312
Copy link
Contributor

sruti1312 commented Jul 11, 2022

Thanks for the PR @prudhvigodithi. build.gradle needs to be included.

include(name: "build.gradle")

Docker compose file needs to be changed as well during major version releases (2.1 -> 2.2)
https://github.com/opensearch-project/performance-analyzer-rca/blob/main/docker/docker-compose.yml

@prudhvigodithi
Copy link
Member Author

Renaming to task updateVersion following opensearch-project/opensearch-plugin-template-java#32.

@kkhatua kkhatua requested a review from sruti1312 July 18, 2022 18:11
@sruti1312 sruti1312 requested a review from dzane17 July 26, 2022 22:51
@kkhatua kkhatua self-requested a review July 27, 2022 16:15
@prudhvigodithi
Copy link
Member Author

Hey Just checking back to see if we can merge this PR?
Thank you

@sruti1312 sruti1312 merged commit 62c5129 into opensearch-project:main Aug 1, 2022
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-197-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 62c5129cd851e7b7717f810f6cc1d1797c249a9e
# Push it to GitHub
git push --set-upstream origin backport/backport-197-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-197-to-1.x.

@prudhvigodithi
Copy link
Member Author

Hey @sruti1312 do you know the backport workflow works, else I will raise a manual PR for all the release branches?
Thank you

@prudhvigodithi
Copy link
Member Author

prudhvigodithi commented Aug 2, 2022

Hey @sruti1312 @kkhatua we need this change for all the release branches main, 2.x and 1.x, I dont see 2.x and 1.x branches exists, there is an open issue related to this topic #199, can you please check.
Thank you
@bbarani @CEHENKLE @dblock

kaushalmahi12 pushed a commit to kaushalmahi12/performance-analyzer-rca that referenced this pull request Aug 11, 2022
* version increment automation

Signed-off-by: pgodithi <pgodithi@amazon.com>

* version increment automation

Signed-off-by: pgodithi <pgodithi@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/performance-analyzer-rca that referenced this pull request Aug 12, 2022
* version increment automation

Signed-off-by: pgodithi <pgodithi@amazon.com>

* version increment automation

Signed-off-by: pgodithi <pgodithi@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/performance-analyzer-rca that referenced this pull request Aug 12, 2022
* version increment automation

Signed-off-by: pgodithi <pgodithi@amazon.com>

* version increment automation

Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: Kaushal Kumar <kshkmr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants