Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add privileges for removing files #45

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Aug 14, 2021

Signed-off-by: Sruti Parthiban partsrut@amazon.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#38

Describe the solution you are proposing
Calling the delete methods with privilege.

Tested by spinning up a docker and confirmed that files are cleaned as expected.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
@sruti1312 sruti1312 requested review from kjoseph07 and kkhatua August 14, 2021 01:27
@sruti1312 sruti1312 merged commit 2cbc697 into main Aug 17, 2021
@sruti1312 sruti1312 deleted the feature/add-privileges branch August 17, 2021 21:43
sruti1312 added a commit that referenced this pull request Aug 25, 2021
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
sruti1312 added a commit that referenced this pull request Aug 25, 2021
* Adding the initial changes for purger fix

* Removing deletionInterval from MetricConfig class

* Moving the removeMetrics() back to PerformanceAnalyzerMetrics class

* Adding Event log file deletion + deletion time metric

* Updating the EventLogFilesDeleted metrics

* Moving METRICS_WRITE_ERROR metric to Named Counter, updating deleteFiles() signature

* nit: Removing an unused import

* Addressing the spotbug failure

* Fixing the linker error, updating from docs-beta to official documentation

* Excluding https://www.envoyproxy.io/ from link checker. Failing with too many redirects

* Create writer file only if metrics are present (#23)

* Create writer file only if metrics are present

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Add metrics to writers metric

* Rename writer_file_creation metric name

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Update the statistic for the metric

* Spotless changes

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Add privileges for removing files (#45)

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>

* Remove spotless dependency on main (#54)

This PR removes the need for the main branch to be checked out
in order to build.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Upgrade to version 1.0.1

Co-authored-by: Khushboo Rajput <khushbr@amazon.com>
Co-authored-by: Khushboo Rajput <59671881+khushbr@users.noreply.github.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
eirsep pushed a commit to eirsep/performance-analyzer-rca that referenced this pull request Sep 6, 2021
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants