Gradle 7, JDK related changes and OS 2.0 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
sgup432
force-pushed
the
jdk_gradle_7_OS2.0
branch
from
ed21eea to
64b8d81
Compare
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
============================================
- Coverage 72.29% 71.77% -0.53%
+ Complexity 358 356 -2
============================================
Files 44 44
Lines 2516 2459 -57
Branches 167 160 -7
============================================
- Hits 1819 1765 -54
+ Misses 592 588 -4
- Partials 105 106 +1
Continue to review full report at Codecov.
|
sruti1312
approved these changes
Apr 7, 2022
| @@ -106,42 +106,6 @@ private void populateCurrentShards() { | |||
| put( | |||
| ShardStatsValue.SEGMENTS_TOTAL.toString(), | |||
| (shardStats) -> shardStats.getStats().getSegments().getCount()); | |||
| put( | |||
| ShardStatsValue.SEGMENTS_MEMORY.toString(), | |||
There was a problem hiding this comment.
Do we want to remove the related Metrics as well?
There was a problem hiding this comment.
Like from RCA package or something else? I will get out a separate PR for RCA related changes.
dzane17
approved these changes
Apr 7, 2022
24 tasks
1 task
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sagar Upadhyaya sagar.upadhyaya.121@gmail.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Temporarily pointing to local RCA repo to test build/CI.
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.