-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force pull from defined origin to avoid ambiguity #245
Merged
peterzhuamazon
merged 6 commits into
opensearch-project:main
from
peterzhuamazon:test_2.2.0
Aug 8, 2022
Merged
Force pull from defined origin to avoid ambiguity #245
peterzhuamazon
merged 6 commits into
opensearch-project:main
from
peterzhuamazon:test_2.2.0
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@amazon.com> Co-authored-by: Sagar Upadhyaya <sagar.upadhyaya.121@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
48 tasks
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
sgup432
reviewed
Aug 8, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
sruti1312
approved these changes
Aug 8, 2022
BWC tests are failing with the following error,
|
We have fixed the issue on |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
sgup432
approved these changes
Aug 8, 2022
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Force pull from defined origin to avoid ambiguity
Describe the solution you are proposing
Previously all the calls of fetch are using string like
main
in branch name, but2.2
breaks it and cause the fetch to use float which somehow breaks Grgit. Force pulling oforigin/2.2
fix the issue.Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.