Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force pull from defined origin to avoid ambiguity #245

Merged
merged 6 commits into from
Aug 8, 2022

Conversation

peterzhuamazon
Copy link
Member

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Force pull from defined origin to avoid ambiguity

Describe the solution you are proposing
Previously all the calls of fetch are using string like main in branch name, but 2.2 breaks it and cause the fetch to use float which somehow breaks Grgit. Force pulling of origin/2.2 fix the issue.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

sgup432 and others added 2 commits August 5, 2022 18:46
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@amazon.com>

Co-authored-by: Sagar Upadhyaya <sagar.upadhyaya.121@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon changed the base branch from main to 2.2 August 8, 2022 17:26
@peterzhuamazon peterzhuamazon changed the base branch from 2.2 to main August 8, 2022 17:27
build.gradle Outdated Show resolved Hide resolved
@sgup432 sgup432 requested a review from sruti1312 August 8, 2022 17:28
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@sruti1312
Copy link
Contributor

BWC tests are failing with the following error,

Build file '/home/runner/work/performance-analyzer/performance-analyzer/tmp/performance-analyzer/build.gradle' line: 587

* What went wrong:
Could not determine the dependencies of task ':paBwcCluster#rollingUpgradeClusterTask'.
> No subject alternative DNS name matching ci.opensearch.org found.

@peterzhuamazon
Copy link
Member Author

We have fixed the issue on ci.opensearch.org and will try again.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release v2.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants