Move query categorization changes to plugin #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 tasks
deshsidd
changed the title
3 tasks
deshsidd
force-pushed
the
sid/move-query-categorization
branch
from
691838d to
c332bd9
Compare
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
deshsidd
force-pushed
the
sid/move-query-categorization
branch
from
c332bd9 to
6b925be
Compare
Closed
3 tasks
ansjcy
reviewed
Jul 17, 2024
src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/service/QueryInsightsService.java
Show resolved
Hide resolved
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
ansjcy
reviewed
Jul 17, 2024
src/main/java/org/opensearch/plugin/insights/core/listener/QueryInsightsListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
ansjcy
approved these changes
Jul 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Move query categorization changes to plugin Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Fix SearchSourceBuilder read/write test failures Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Fix tests Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Fix starting and stopping query insights service Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Unit tests for feature enable/disable and refactor logic Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> --------- Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> (cherry picked from commit 811f4a5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Move query categorization changes to plugin Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Fix SearchSourceBuilder read/write test failures Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Fix tests Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Fix starting and stopping query insights service Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Unit tests for feature enable/disable and refactor logic Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> --------- Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> (cherry picked from commit 811f4a5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 811f4a5) Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 811f4a5) Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR : opensearch-project/OpenSearch#14528
Query categorization changes to increment counters for search query related metrics currently resides on the search path and occurs before the request.
Move these changes to the query insights plugin and make sure the incrementing of counters happens separately from the search path.
Another option is to keep query categorization changes as is. However, this will lead to additional overhead on the search path. Furthermore, we need to tie query latency, cpu, memory with the query categorization data which will only be possible if we increment the counters after the request is completed and the query latency and resource usage data resides inside the plugin.
To support the above and to prevent doing these counter increments on the search path, we need to move query categorization changes to the query insights plugin.
Related Issues
Resolves opensearch-project/OpenSearch#14527
Addresses opensearch-project/OpenSearch#11596
Check List
Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.