Remove local index custom name setting #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzane17
requested review from
ansjcy,
jainankitk and
deshsidd
as code owners
ansjcy
reviewed
Dec 10, 2024
src/main/java/org/opensearch/plugin/insights/core/exporter/QueryInsightsExporterFactory.java
Outdated
Show resolved
Hide resolved
dzane17
force-pushed
the
local-index-name
branch
from
0219542 to
512a4fc
Compare
Signed-off-by: David Zane <davizane@amazon.com>
dzane17
force-pushed
the
local-index-name
branch
from
512a4fc to
a830dd4
Compare
deshsidd
approved these changes
Dec 11, 2024
ansjcy
approved these changes
Dec 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
Signed-off-by: David Zane <davizane@amazon.com> (cherry picked from commit a97099c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dzane17
pushed a commit
that referenced
this pull request
Dec 12, 2024
Signed-off-by: David Zane <davizane@amazon.com> (cherry picked from commit a97099c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dzane17
pushed a commit
that referenced
this pull request
Dec 12, 2024
(cherry picked from commit a97099c) Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query Insights allows users to specify a custom index name for storing Top N data via the
search.insights.top_queries.latency.exporter.config.indexcluster setting. However, this flexibility introduces ambiguity. If users change the local index naming pattern, Query Insights will lose track of previously created indices, preventing dashboards from accessing historical data and hindering retention management.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.