-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add backport github actions #17
add backport github actions #17
Conversation
4588301
to
dfc0774
Compare
installation_id: 22958780 | ||
|
||
- name: Backport | ||
uses: VachaShah/backport@v2.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use one of the maintainers on QueryInsights repo instead of Vacha?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this is used across all plugin repos as well, for example: https://github.com/opensearch-project/alerting/blob/main/.github/workflows/backport.yml#L26
with: | ||
app_id: ${{ secrets.APP_ID }} | ||
private_key: ${{ secrets.APP_PRIVATE_KEY }} | ||
installation_id: 22958780 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the installation_id be same as core repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also used across all plugins, another example: https://github.com/opensearch-project/security-analytics/blob/main/.github/workflows/backport.yml#L23
Signed-off-by: Chenyang Ji <cyji@amazon.com>
dfc0774
to
4f9c27e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit 0472a96) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit 0472a96) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Chenyang Ji <cyji@amazon.com> (cherry picked from commit 0472a96) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add github actions for backport
Issues Resolved
This is related to #7
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.