Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backport github actions #17

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Jul 15, 2024

Description

Add github actions for backport

Issues Resolved

This is related to #7

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ansjcy ansjcy force-pushed the add-backport-github-actions branch 2 times, most recently from 4588301 to dfc0774 Compare July 15, 2024 23:49
installation_id: 22958780

- name: Backport
uses: VachaShah/backport@v2.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use one of the maintainers on QueryInsights repo instead of Vacha?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this is used across all plugin repos as well, for example: https://github.com/opensearch-project/alerting/blob/main/.github/workflows/backport.yml#L26

with:
app_id: ${{ secrets.APP_ID }}
private_key: ${{ secrets.APP_PRIVATE_KEY }}
installation_id: 22958780
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the installation_id be same as core repo?

Copy link
Member Author

@ansjcy ansjcy Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Chenyang Ji <cyji@amazon.com>
@ansjcy ansjcy force-pushed the add-backport-github-actions branch from dfc0774 to 4f9c27e Compare July 16, 2024 00:19
Copy link
Collaborator

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansjcy ansjcy merged commit 0472a96 into opensearch-project:main Jul 16, 2024
10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 16, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 0472a96)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 16, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 0472a96)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy pushed a commit that referenced this pull request Jul 16, 2024
(cherry picked from commit 0472a96)

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy pushed a commit that referenced this pull request Jul 17, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 0472a96)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy pushed a commit that referenced this pull request Jul 17, 2024
(cherry picked from commit 0472a96)

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants