Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration] Reports-scheduler renaming, version reset, fix CI workflow #22

Merged
merged 5 commits into from
Apr 26, 2021

Conversation

zhongnansu
Copy link
Member

Description

  1. rename plugin to opensearch-reports-scheduler-1.0.0.0-beta1
  2. fix related UT/IT
  3. Fix CI workflow to use maven local
  4. update gradle build to use maven local
  5. passed all IT/UT

TODO:

  1. migrate release-notes

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zhongnansu zhongnansu marked this pull request as ready for review April 25, 2021 20:57
@zhongnansu zhongnansu requested review from akbhatta, joshuali925 and davidcui1225 and removed request for joshuali925 April 25, 2021 20:57
Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- how come we are keeping reports-scheduler in beta?

@zhongnansu zhongnansu force-pushed the opensearch/reports-scheduler-beta-1 branch from b2c19ca to 7a49830 Compare April 26, 2021 18:32
@zhongnansu zhongnansu merged commit 1e6b521 into dev Apr 26, 2021
kavilla pushed a commit to kavilla/dashboards-reports that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants