Split repository into separate plugins #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would like to be able to install a plugin that supports reranking with Amazon Personalize without automatically getting Amazon Kendra Intelligent Ranking too. Users should be able to choose which external reranker(s) they want to use and install plugins for each. opensearch-project#190 Signed-off-by: Michael Froh <froh@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
============================================
- Coverage 83.39% 83.26% -0.14%
Complexity 334 334
============================================
Files 42 43 +1
Lines 1259 1261 +2
Branches 154 154
============================================
Hits 1050 1050
- Misses 132 134 +2
Partials 77 77
|
msfroh
requested review from
macohen,
noCharger,
mingshl and
sejli
as code owners
sejli
approved these changes
Aug 17, 2023
|
This PR also addresses refactoring done in OpenSearch core, which should fix the daily builds. Thanks for updating the imports as well! 🎉 |
|
Ignoring codecov, because it's confused about the coverage since it's ignoring all the moved files. |
msfroh
added
backport 2.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-191-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eb77879e694ca609929b0c1098620a6ebea4afda
# Push it to GitHub
git push --set-upstream origin backport/backport-191-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
(cherry picked from commit eb77879)
noCharger
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Split repository into separate plugins (#191) (cherry picked from commit eb77879) * Fix backport to 2.x We need to specify the opensearch version in two places now (until we figure out how to set it in one place), and need to switch to Apache HttpClient 4 on the 2.x branch. Signed-off-by: Michael Froh <froh@amazon.com> --------- Signed-off-by: Michael Froh <froh@amazon.com> Co-authored-by: Michael Froh <froh@amazon.com>
msfroh
added a commit
that referenced
this pull request
Aug 22, 2023
…192) * Split repository into separate plugins (#191) (cherry picked from commit eb77879) * Fix backport to 2.x We need to specify the opensearch version in two places now (until we figure out how to set it in one place), and need to switch to Apache HttpClient 4 on the 2.x branch. Signed-off-by: Michael Froh <froh@amazon.com> --------- Signed-off-by: Michael Froh <froh@amazon.com> Co-authored-by: Michael Froh <froh@amazon.com> (cherry picked from commit 182937d) Signed-off-by: Michael Froh <froh@amazon.com>
msfroh
added a commit
that referenced
this pull request
Aug 22, 2023
…192) (#193) * Split repository into separate plugins (#191) (cherry picked from commit eb77879) * Fix backport to 2.x We need to specify the opensearch version in two places now (until we figure out how to set it in one place), and need to switch to Apache HttpClient 4 on the 2.x branch. --------- (cherry picked from commit 182937d) Signed-off-by: Michael Froh <froh@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We would like to be able to install a plugin that supports reranking with Amazon Personalize without automatically getting Amazon Kendra Intelligent Ranking too. Users should be able to choose which external reranker(s) they want to use and install plugins for each.
Issues Resolved
#190
Check List
[ ] New functionality includes testing.[ ] All tests pass[ ] New functionality has been documented.[ ] New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.