-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/backport 383 to 2.x units fix #425
Merged
amsiglan
merged 2 commits into
opensearch-project:backport/backport-383-to-2.x
from
jovancacvetkovic:backport/backport-383-to-2.x-units-fix
Feb 21, 2023
Merged
Backport/backport 383 to 2.x units fix #425
amsiglan
merged 2 commits into
opensearch-project:backport/backport-383-to-2.x
from
jovancacvetkovic:backport/backport-383-to-2.x-units-fix
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
amsiglan
added
the
backport 2.6
Used for marking changes that must be merged into 2.6 branch
label
Feb 21, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-425-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 280a981a28b0f3636a24167be353780c962feb21
# Push it to GitHub
git push --set-upstream origin backport/backport-425-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6 Then, create a pull request where the |
amsiglan
pushed a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 21, 2023
* unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
amsiglan
added a commit
that referenced
this pull request
Feb 21, 2023
* Unit tests for public components (#383) * [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Create detector | Interval field can be empty #378 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature/update vertical domain #372 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * PR code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * PR code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit 0150c89) * Backport/backport 383 to 2.x units fix (#425) * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fixed mock (#430) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Updated snapshot for 383 backport (#431) * fixed mock Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Feb 21, 2023
* Unit tests for public components (#383) * [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Create detector | Interval field can be empty #378 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature/update vertical domain #372 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * PR code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * PR code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit 0150c89) * Backport/backport 383 to 2.x units fix (#425) * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fixed mock (#430) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Updated snapshot for 383 backport (#431) * fixed mock Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit b5e53ab)
amsiglan
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Unit tests for public components (#383) * [FEATURE] Detector must have at least one alert set #288 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Create detector | Interval field can be empty #378 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Adjust styling for Finding details flyout #369 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature/update vertical domain #372 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components #383 [BUG] Detector Edit | Custom rule are not selected on update rules #406 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * PR code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * PR code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit 0150c89) * Backport/backport 383 to 2.x units fix (#425) * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fixed mock (#430) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Updated snapshot for 383 backport (#431) * fixed mock Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit b5e53ab) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
* Unit tests for public components (opensearch-project#383) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Create detector | Interval field can be empty opensearch-project#378 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Adjust styling for Finding details flyout opensearch-project#369 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature/update vertical domain opensearch-project#372 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 [BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 [BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * PR code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * PR code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit 0150c89) * Backport/backport 383 to 2.x units fix (opensearch-project#425) * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fixed mock (opensearch-project#430) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Updated snapshot for 383 backport (opensearch-project#431) * fixed mock Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
* Unit tests for public components (opensearch-project#383) * [FEATURE] Detector must have at least one alert set opensearch-project#288 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Create detector | Interval field can be empty opensearch-project#378 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Adjust styling for Finding details flyout opensearch-project#369 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * detector unit tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature/update vertical domain opensearch-project#372 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 [BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Unit tests for public components opensearch-project#383 [BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * PR code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * PR code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> (cherry picked from commit 0150c89) * Backport/backport 383 to 2.x units fix (opensearch-project#425) * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * unit tests fix Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fixed mock (opensearch-project#430) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Updated snapshot for 383 backport (opensearch-project#431) * fixed mock Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes unit tests
Issues Resolved
#416
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.