Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test167 #299

Closed
wants to merge 9 commits into from
Closed

Test167 #299

wants to merge 9 commits into from

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Jan 12, 2023

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@sbcd90 sbcd90 requested a review from a team January 12, 2023 02:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Merging #299 (f18ada7) into main (78ea8be) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##               main     #299      +/-   ##
============================================
- Coverage     36.96%   36.89%   -0.07%     
  Complexity      887      887              
============================================
  Files           179      179              
  Lines          7010     7028      +18     
  Branches        855      857       +2     
============================================
+ Hits           2591     2593       +2     
- Misses         4182     4198      +16     
  Partials        237      237              
Impacted Files Coverage Δ
...rch/securityanalytics/action/GetAlertsRequest.java 0.00% <0.00%> (ø)
...h/securityanalytics/action/GetFindingsRequest.java 0.00% <0.00%> (ø)
...curityanalytics/action/GetMappingsViewRequest.java 0.00% <0.00%> (ø)
...securityanalytics/action/ValidateRulesRequest.java 57.14% <0.00%> (ø)
...securityanalytics/mapper/IndexTemplateManager.java 0.00% <0.00%> (ø)
...search/securityanalytics/mapper/MapperService.java 4.61% <0.00%> (+0.06%) ⬆️
...earch/securityanalytics/model/DetectorTrigger.java 56.14% <0.00%> (ø)
...a/org/opensearch/securityanalytics/model/Rule.java 0.00% <0.00%> (ø)
...ytics/resthandler/RestAcknowledgeAlertsAction.java 0.00% <ø> (ø)
...nalytics/resthandler/RestDeleteDetectorAction.java 0.00% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 closed this Jan 12, 2023
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Change colors for Alerts STATUS chart opensearch-project#299
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Change colors for Alerts STATUS chart opensearch-project#299
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Change colors for Alerts STATUS chart opensearch-project#299
[BUG] Change color for Alerts SEVERITY chart opensearch-project#300
[BUG] Change color for Finding RULE SEVERITY chart opensearch-project#301

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
)

* Adding ITs to check for Default Role Permissions

Signed-off-by: Aditya Jindal <aditjind@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants