Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds findingIds as a search parameter for alerts #794

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adds findingIds as a search parameter for alerts #794

wants to merge 4 commits into from

Conversation

ishanbhat2004
Copy link

Description

Using FindingIds as an additional parameter to generate appropriate alerts

Issues Resolved

#615

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ishanbhat2004
Extends search to support findingIds
5a100ec 
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
@ishanbhat2004
Adds method to convert string findingIds to a list and update relevan…
5362e44 
…t files

Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
@ishanbhat2004
Fix function calls using findingIds
2587423 
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
@ishanbhat2004
Update Alerting tests to accomodate findingIds parameter
9c42561 
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
@raj-chak
fixed security tests (opensearch-project#484) (opensearch-project#794)
3531a99 
* fixed security tests

Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
(cherry picked from commit c51940f5e2d14a00262f7f4675bbba2d930d2ede)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@AWSHurneyt AWSHurneyt Awaiting requested review from AWSHurneyt AWSHurneyt is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

@jowg-amazon jowg-amazon Awaiting requested review from jowg-amazon jowg-amazon is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ishanbhat2004