Apply suggestions from code review

Co-authored-by: Peter Nied <peternied@hotmail.com> Signed-off-by: Kajetan Nobel <k.nobel@routegroup.pl>
opensearch-project · Oct 30, 2023 · 798ca64 · 798ca64
1 parent 8ec5413
commit 798ca64
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/server/readonly/readonly_service.ts b/server/readonly/readonly_service.ts
@@ -65,12 +65,13 @@ export class ReadonlyService extends BaseReadonlyService {
   isReadOnlyTenant(authInfo: OpenSearchAuthInfo): boolean {
     const currentTenant = authInfo.user_requested_tenant || globalTenantName;
 
-    // private tenant is not affected
+    // private tenants are isolated to individual users that always have read/write permissions
     if (isPrivateTenant(currentTenant)) {
       return false;
     }
 
-    return authInfo.tenants[currentTenant] !== true;
+    let readWriteAccess = authInfo.tenants[currentTenant];
+    return !readWriteAccess;
   }
 
   async isReadonly(request: OpenSearchDashboardsRequest): Promise<boolean> {