-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to maven to download plugin snapshots #1331
Switch to maven to download plugin snapshots #1331
Conversation
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied Should the backport 2.x label be added? |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1331 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 88 88
Lines 2027 2027
Branches 274 274
=======================================
Hits 1455 1455
Misses 509 509
Partials 63 63 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
||
- name: Rename the Plugin Files | ||
run: mv opensearch-security-${{ inputs.plugin-version }}.zip opensearch-security.zip | ||
- run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a name
for this task, so that it is easy to track in the terminal. The rest looks good to me!
Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a039441)
Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a039441)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1331-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a0394415cd0f3cefad39c4cac9f7c9d6c23a62d1
# Push it to GitHub
git push --set-upstream origin backport/backport-1331-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
Description
The Security Plugin publishing snapshots of its build through maven. Switching from the distribution build to these maven based artifacts.
Note; The security plugin does not publish these artifacts for version 1.x so this change should not be backported.
Issues Resolved
Testing
This change is tested through GitHub Actions associated with this project
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.