Lift state up one and generalize flow, render picker for auth tab #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/supporting-multiple-datasources #1835 +/- ##
===========================================================================
+ Coverage 67.65% 67.91% +0.25%
===========================================================================
Files 95 95
Lines 2427 2431 +4
Branches 330 330
===========================================================================
+ Hits 1642 1651 +9
+ Misses 707 702 -5
Partials 78 78 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
commented
Mar 21, 2024
| @@ -748,19 +755,27 @@ export function defineRoutes(router: IRouter, dataSourceEnabled: boolean) { | |||
| { | |||
| path: `${API_PREFIX}/configuration/cache`, | |||
| validate: { | |||
| body: schema.object({ | |||
| query: schema.object({ | |||
There was a problem hiding this comment.
Change to query since GET doesn't support body
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
cwperks
reviewed
Mar 22, 2024
cwperks
reviewed
Mar 22, 2024
cwperks
reviewed
Mar 22, 2024
cwperks
reviewed
Mar 22, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
stephen-crawford
approved these changes
Mar 22, 2024
| .set(AUTHORIZATION_HEADER_NAME, ADMIN_CREDENTIALS); | ||
|
|
||
| // Getting auth info on a datasource that does not exist | ||
| expect(getAuthResponseWrongDataSource.status).not.toEqual(200); |
There was a problem hiding this comment.
Nit: This should probably be an assertion against the error code i.e. 500
peternied
merged commit eae331a
into
opensearch-project:feature/supporting-multiple-datasources
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports multi datasources for the "Authentication Tab". Lifts the state up to be managed/saved across Get Started and Authentication tabs.
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Screen.Recording.2024-03-20.at.3.15.40.PM.mov
Issues Resolved
Fix: #1797, Fix: #1816
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.