Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenSearch core dependency version to 1.2.0 #1482

Merged

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Nov 2, 2021

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Maintenance

  2. Github Issue # or road-map entry, if available:
    Release version 1.2 #1459

  3. Description of changes:

  • Update the OpenSearch core dependency version to 1.2.0
  • No longer building OpenSearch core artifact in CD workflow
  1. Why these changes are required?
    OpenSearch 1.2.0 release readiness

  2. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  3. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

  1. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  2. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cliu123 cliu123 requested review from a team and dblock November 2, 2021 01:29
@cliu123 cliu123 force-pushed the update_opensearch_version_to_1.2.0 branch 2 times, most recently from 5a420d4 to 36fa03b Compare November 2, 2021 01:42
@cliu123
Copy link
Member Author

cliu123 commented Nov 2, 2021

Will rebase the branch and re-run CI after PR#1479 gets merged.

Signed-off-by: cliu123 <lc12251109@gmail.com>
@cliu123 cliu123 force-pushed the update_opensearch_version_to_1.2.0 branch from 36fa03b to 25a023e Compare November 2, 2021 16:24
@codecov-commenter
Copy link

Codecov Report

Merging #1482 (25a023e) into main (235c475) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1482      +/-   ##
============================================
+ Coverage     64.88%   64.90%   +0.02%     
- Complexity     3229     3231       +2     
============================================
  Files           247      247              
  Lines         17335    17335              
  Branches       3072     3072              
============================================
+ Hits          11247    11252       +5     
+ Misses         4532     4527       -5     
  Partials       1556     1556              
Impacted Files Coverage Δ
...security/configuration/DlsFlsFilterLeafReader.java 59.76% <0.00%> (-0.71%) ⬇️
...ecurity/configuration/ConfigurationRepository.java 75.27% <0.00%> (+2.19%) ⬆️
...nsearch/security/dlic/rest/api/AuditApiAction.java 68.08% <0.00%> (+4.25%) ⬆️
...ecurity/configuration/StaticResourceException.java 25.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235c475...25a023e. Read the comment docs.

@cliu123 cliu123 merged commit 42b118b into opensearch-project:main Nov 2, 2021
@cliu123 cliu123 deleted the update_opensearch_version_to_1.2.0 branch November 2, 2021 18:11
@cliu123 cliu123 added the maintenance Project maintenance label Nov 8, 2021
lbreinig pushed a commit to lbreinig/security that referenced this pull request Dec 23, 2021
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
gaobinlong pushed a commit to gaobinlong/security that referenced this pull request Aug 30, 2023
…search-project#1482)

* filter high level groups and action groups by cluster and index

Signed-off-by: Derek Ho <dxho@amazon.com>

* remove unecessary console

Signed-off-by: Derek Ho <dxho@amazon.com>

* add semicolon back

Signed-off-by: Derek Ho <dxho@amazon.com>

* use map instead of flat map

Signed-off-by: Derek Ho <dxho@amazon.com>

* fix lint

Signed-off-by: Derek Ho <dxho@amazon.com>

* fix tests

Signed-off-by: Derek Ho <dxho@amazon.com>

* revert file

Signed-off-by: Derek Ho <dxho@amazon.com>

* fix up tests

Signed-off-by: Derek Ho <dxho@amazon.com>

* lint

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants