Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowlist configuration and deprecate whitelist #1808

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Apr 28, 2022

Description

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Refactoring

Issues Resolved

#1665

Testing

UTs

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cliu123 cliu123 requested a review from a team April 28, 2022 23:42
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #1808 (71f0eff) into main (e189b7a) will decrease coverage by 0.06%.
The diff coverage is 56.86%.

@@             Coverage Diff              @@
##               main    #1808      +/-   ##
============================================
- Coverage     60.81%   60.74%   -0.07%     
- Complexity     3187     3205      +18     
============================================
  Files           253      256       +3     
  Lines         17931    18016      +85     
  Branches       3204     3210       +6     
============================================
+ Hits          10904    10944      +40     
- Misses         5450     5490      +40     
- Partials       1577     1582       +5     
Impacted Files Coverage Δ
...rg/opensearch/security/securityconf/Migration.java 53.33% <0.00%> (-4.33%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 37.31% <0.00%> (-0.19%) ⬇️
...curity/securityconf/impl/AllowlistingSettings.java 33.33% <33.33%> (ø)
...ch/security/securityconf/DynamicConfigFactory.java 56.05% <66.66%> (+0.78%) ⬆️
...rch/security/dlic/rest/api/AllowlistApiAction.java 74.19% <74.19%> (ø)
...opensearch/security/filter/SecurityRestFilter.java 76.19% <75.00%> (-0.48%) ⬇️
...ty/configuration/ConfigurationLoaderSecurity7.java 65.57% <100.00%> (ø)
...ecurity/configuration/ConfigurationRepository.java 72.13% <100.00%> (-2.05%) ⬇️
...rg/opensearch/security/dlic/rest/api/Endpoint.java 100.00% <100.00%> (ø)
...security/dlic/rest/api/SecurityRestApiActions.java 94.73% <100.00%> (+0.29%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e189b7a...71f0eff. Read the comment docs.

@cliu123 cliu123 requested review from peternied, DarshitChanpura and a team May 3, 2022 06:15
DarshitChanpura
DarshitChanpura previously approved these changes May 3, 2022
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that last round of feedback and I've done a pass over the new test code.

cliu123 added 8 commits May 4, 2022 15:50
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
…ng rh.keystore in tests

Signed-off-by: cliu123 <lc12251109@gmail.com>
@cliu123 cliu123 force-pushed the add_allowlist_configuration_and_deprecate_whitelist branch from 3f10c17 to 979d893 Compare May 6, 2022 05:29
Signed-off-by: cliu123 <lc12251109@gmail.com>
@cliu123 cliu123 force-pushed the add_allowlist_configuration_and_deprecate_whitelist branch from 6c2c728 to 55d4a2b Compare May 6, 2022 05:49
cliu123 added 3 commits May 9, 2022 10:43
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
…Settings

Signed-off-by: cliu123 <lc12251109@gmail.com>
@cliu123 cliu123 force-pushed the add_allowlist_configuration_and_deprecate_whitelist branch from 5792070 to 4cad2c2 Compare May 11, 2022 22:55
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements all around, thanks for the dedication @cliu123!

wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants