-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allowlist configuration and deprecate whitelist #1808
Add allowlist configuration and deprecate whitelist #1808
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1808 +/- ##
============================================
- Coverage 60.81% 60.74% -0.07%
- Complexity 3187 3205 +18
============================================
Files 253 256 +3
Lines 17931 18016 +85
Branches 3204 3210 +6
============================================
+ Hits 10904 10944 +40
- Misses 5450 5490 +40
- Partials 1577 1582 +5
Continue to review full report at Codecov.
|
src/main/java/org/opensearch/security/dlic/rest/api/AllowlistApiAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/api/MigrateApiAction.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AllowlistApiTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AllowlistApiTest.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/api/AllowlistApiAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/configuration/ConfigurationLoaderSecurity7.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/configuration/ConfigurationRepository.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on that last round of feedback and I've done a pass over the new test code.
src/main/java/org/opensearch/security/dlic/rest/api/AllowlistApiAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/securityconf/impl/AllowlistingSettings.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/configuration/ConfigurationLoaderSecurity7.java
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AllowlistApiTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AllowlistApiTest.java
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AllowlistApiTest.java
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AllowlistApiTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AllowlistApiTest.java
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AllowlistApiTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AllowlistApiTest.java
Show resolved
Hide resolved
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
…ng rh.keystore in tests Signed-off-by: cliu123 <lc12251109@gmail.com>
3f10c17
to
979d893
Compare
Signed-off-by: cliu123 <lc12251109@gmail.com>
6c2c728
to
55d4a2b
Compare
Signed-off-by: cliu123 <lc12251109@gmail.com>
Signed-off-by: cliu123 <lc12251109@gmail.com>
…Settings Signed-off-by: cliu123 <lc12251109@gmail.com>
5792070
to
4cad2c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements all around, thanks for the dedication @cliu123!
…ct#1808) Signed-off-by: cliu123 <lc12251109@gmail.com>
Description
Issues Resolved
#1665
Testing
UTs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.