Remove master keywords

[cliu123]

Description

[Describe what this change achieves]

• Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Refactoring

Issues Resolved

#1664

Testing

ITs

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peternied]

Please update https://github.com/opensearch-project/security/blob/main/config/checkstyle/sun_checks.xml#L204 to an error.

Will there be a separate PR for the whitelist terminology?

[cliu123]

https://github.com/opensearch-project/security/blob/main/config/checkstyle/sun_checks.xml#L204

The check cannot be enabled as some master keywords referencing to OpenSearch core, for example node.master.
Whitelist is not going to be removed until OpenSearch 3.0.

[codecov-commenter]

Codecov Report

Merging #1886 (ba0a009) into main (001d73f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1886      +/-   ##
============================================
+ Coverage     61.01%   61.04%   +0.03%     
- Complexity     3232     3233       +1     
============================================
  Files           256      256              
  Lines         18085    18085              
  Branches       3222     3222              
============================================
+ Hits          11034    11040       +6     
+ Misses         5469     5466       -3     
+ Partials       1582     1579       -3     

Impacted Files	Coverage Δ
...arch/security/configuration/ClusterInfoHolder.java	65.85% <100.00%> (ø)
.../security/privileges/SnapshotRestoreEvaluator.java	96.96% <100.00%> (ø)
...earch/security/resolver/IndexResolverReplacer.java	65.52% <100.00%> (ø)
...earch/security/ssl/util/SSLConnectionTestUtil.java	95.45% <0.00%> (+2.27%)	⬆️
...urity/ssl/transport/SecuritySSLNettyTransport.java	66.66% <0.00%> (+4.30%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 001d73f...ba0a009. Read the comment docs.

[peternied]

The check cannot be enabled as some master keywords referencing to OpenSearch core, for example node.master.

Shouldn't we be able to switch to something like node.cluster_manager? We should be able to remove all of the 'master' based language from this codebase, or its a bug on OpenSearch.

[cliu123]

The check cannot be enabled as some master keywords referencing to OpenSearch core, for example node.master.

Shouldn't we be able to switch to something like node.cluster_manager? We should be able to remove all of the 'master' based language from this codebase, or its a bug on OpenSearch.

node.cluster_manager is not a valid configuration in OpenSearch core.

[peternied]

node.cluster_manager is not a valid configuration in OpenSearch core.

If this is the case, we should have bugs on OpenSearch because our migration effort is blocked.

To keep this effort moving could you create issues on any OpenSearch blockers and then use checkstyle exclusion comments so we can merge the progress that you've made while we chase down these outstanding items. What do you think of this?

[cliu123]

@peternied I've listed out the items that we cannot change in the OpenSearch issue and the security plugin issue. So we can unblock this PR.

[davidlago]

Could you please create a follow-up issue in our repo to come back and update the missing ones you reported in opensearch-project/OpenSearch#472 (comment) once they get addressed?

[cliu123]

Could you please create a follow-up issue in our repo to come back and update the missing ones you reported in opensearch-project/OpenSearch#472 (comment) once they get addressed?

I've created a separate issue to track the changes in Java APIs when OpenSearch core is ready: #1887