-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add groupId = org.opensearch.plugin #2158
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2158 +/- ##
============================================
- Coverage 61.12% 61.09% -0.04%
+ Complexity 3263 3261 -2
============================================
Files 259 259
Lines 18331 18332 +1
Branches 3250 3250
============================================
- Hits 11205 11200 -5
- Misses 5535 5538 +3
- Partials 1591 1594 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hey waiting on for this bug opensearch-project/OpenSearch#4733 (comment) to be fixed |
8bff8ac
Hey @peternied and @cwperks can you please review again? |
@prudhvigodithi Looks like we are having more build failures on the Before this is merged we should get a PR out to fix the build breaking change. |
See relevant lines in the build output:
|
@prudhvigodithi Can you rebase this PR with the latest changes from main which includes changes that fix the build? |
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
1fae6b9
Hey @cwperks I have just rebased. |
Signed-off-by: prudhvigodithi <pgodithi@amazon.com> (cherry picked from commit 49e7300)
Signed-off-by: prudhvigodithi <pgodithi@amazon.com> Signed-off-by: Stephen Crawford <steecraw@amazon.com>
…ch-project#2185) Signed-off-by: prudhvigodithi <pgodithi@amazon.com> (cherry picked from commit 49e7300) Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: prudhvigodithi pgodithi@amazon.com
Description
Added groupId as org.opensearch.plugin in pluginZip publication
Issues Resolved
#2055
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.