[2.9] Updates common-utils version in integ test script #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
3 tasks
cwperks
approved these changes
Jul 17, 2023
stephen-crawford
approved these changes
Jul 17, 2023
Codecov Report
@@ Coverage Diff @@
## 2.9 #3018 +/- ##
============================================
- Coverage 62.30% 62.22% -0.09%
+ Complexity 3317 3309 -8
============================================
Files 264 264
Lines 19468 19468
Branches 3326 3326
============================================
- Hits 12129 12113 -16
- Misses 5718 5726 +8
- Partials 1621 1629 +8 |
DarshitChanpura
changed the title
peterzhuamazon
approved these changes
Jul 17, 2023
|
Hi, I just have offline talk with @DarshitChanpura on this and suggest:
Thanks. |
Merged
1 task
DarshitChanpura
added a commit
that referenced
this pull request
Aug 9, 2023
…n from build.gradle (#3122) Fixes integTestRemote task to dynamically fetch common-utils version from build.gradle instead of hard-coding it in the shell script * Category : Refactoring * Why these changes are required? A temporary fix (#3018) was added to resolve CI failures in RC generation caused due to out-of-date common-utils version being used in the sanity test. ### Issues Resolved Related to comment: #3018 (comment) **This changes addresses the issue permanently by modifying integTestRemote task to fetch the common-utils version dynamically from build.gradle, and prevent blocking RC builds in future due to such issue** Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
added a commit
to DarshitChanpura/security
that referenced
this pull request
Aug 9, 2023
…n from build.gradle (opensearch-project#3122) Fixes integTestRemote task to dynamically fetch common-utils version from build.gradle instead of hard-coding it in the shell script * Category : Refactoring * Why these changes are required? A temporary fix (opensearch-project#3018) was added to resolve CI failures in RC generation caused due to out-of-date common-utils version being used in the sanity test. Related to comment: opensearch-project#3018 (comment) **This changes addresses the issue permanently by modifying integTestRemote task to fetch the common-utils version dynamically from build.gradle, and prevent blocking RC builds in future due to such issue** Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 46989b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.