[Backport 2.x] System index permissions (#2887) #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
DarshitChanpura
force-pushed
the
backport/backport-2887-to-2.x
branch
from
c0451d7 to
99778a2
Compare
System index permissions Signed-off-by: Sam <samuel.costa@eliatra.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Peter Nied <peternied@hotmail.com> Co-authored-by: Darshit Chanpura <dchanp@amazon.com> Co-authored-by: Peter Nied <peternied@hotmail.com> (cherry picked from commit 1379234)
DarshitChanpura
force-pushed
the
backport/backport-2887-to-2.x
branch
from
99778a2 to
a4bd99d
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #3325 +/- ##
============================================
+ Coverage 63.10% 64.08% +0.98%
- Complexity 3343 3366 +23
============================================
Files 256 256
Lines 19456 19515 +59
Branches 3286 3297 +11
============================================
+ Hits 12277 12507 +230
+ Misses 5584 5364 -220
- Partials 1595 1644 +49
|
|
code-ql is failing because of the new test framework is not present in 2.x: #3230 |
peternied
approved these changes
Sep 7, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #2887 to 2.x
(cherry picked from commit 1379234)
Manual backport was required since SystemIndicesTests.java was deleted in main in lieu of the new testing for system indices. Also had to change http5 imports in tests to http4
Testing
automated tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.