[Backport 2.11] Expanding Authentication with SecurityRequest Abstraction (#3430) #3488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject#3460) Backport 8752074 from opensearch-project#3454. Signed-off-by: David Osorno <daosgu27@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…tion (opensearch-project#3430) Introduced a new abstraction, SecurityRequest & SecurityRequestChannel, to streamline and secure the authentication process in the OpenSearch Security plugin. By isolating the essential request components needed for authentication, we minimize potential risks associated with previous designs and provide a more maintainable architecture. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit f435c05)
peternied
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
DarshitChanpura
approved these changes
Oct 6, 2023
Codecov Report
@@ Coverage Diff @@
## 2.11 #3488 +/- ##
============================================
+ Coverage 64.64% 64.67% +0.03%
- Complexity 3538 3565 +27
============================================
Files 261 267 +6
Lines 19808 19893 +85
Branches 3324 3329 +5
============================================
+ Hits 12804 12866 +62
- Misses 5370 5387 +17
- Partials 1634 1640 +6
|
|
@peternied Can you check the DCO changes. Seems like it is coming from a different PR that will be fixed by: #3480 |
Sometimes on merges DCO can get mixed up. Maintainers such as yourself can go into the check and there is a button to override the failure for circumstances such as this where the tool is being too sensitive and there is the correct sign off on the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of f435c05 from #3430
Introduced a new abstraction, SecurityRequest & SecurityRequestChannel, to streamline and secure the authentication process in the OpenSearch Security plugin. By isolating the essential request components needed for authentication, we minimize potential risks associated with previous designs and provide a more maintainable architecture.
Signed-off-by: Peter Nied petern@amazon.com
(cherry picked from commit f435c05)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.