Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port integration tests #3512

Merged

Conversation

peternied
Copy link
Member

@peternied peternied commented Oct 9, 2023

Description

Forward ports integration test changes from 2.11 and 2.x branches

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peternied and others added 4 commits October 7, 2023 01:54
Test framework that allows for declaring within the test class all
related users, roles, and other security primitives.  Emphasis on
hamcrest Matchers for straight forward to read, author, and
troubleshoot test cases.

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
…requests (opensearch-project#3418) (opensearch-project#3496)

Backport f7c47af from opensearch-project#3495

---------

Signed-off-by: Peter Nied <petern@amazon.com>
Co-authored-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #3512 (4221b8f) into main (6b0b682) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3512      +/-   ##
============================================
+ Coverage     64.71%   64.73%   +0.02%     
- Complexity     3616     3620       +4     
============================================
  Files           281      281              
  Lines         20570    20585      +15     
  Branches       3400     3400              
============================================
+ Hits          13312    13326      +14     
  Misses         5557     5557              
- Partials       1701     1702       +1     
Files Coverage Δ
...sl/http/netty/Netty4HttpRequestHeaderVerifier.java 80.39% <100.00%> (ø)
...dlic/auth/http/saml/AuthTokenProcessorHandler.java 46.40% <0.00%> (ø)
.../org/opensearch/security/auth/BackendRegistry.java 62.41% <50.00%> (ø)
...g/opensearch/security/filter/SecurityResponse.java 92.85% <86.66%> (-7.15%) ⬇️
...opensearch/security/filter/SecurityRestFilter.java 64.84% <33.33%> (ø)

... and 1 file with indirect coverage changes

@cwperks
Copy link
Member

cwperks commented Oct 10, 2023

@peternied The version increment PR in this repo is currently blocked because the PR to add the extension points for the header verifier has not been merged into 2.x yet: opensearch-project/OpenSearch#10442

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good. I have request changes related to HTTPClient 4 as the main is already on hc 5.

build.gradle Outdated Show resolved Hide resolved
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied merged commit 4bfaf9c into opensearch-project:main Oct 11, 2023
58 of 59 checks passed
@peternied peternied deleted the forward-integration-tests branch October 11, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants