add AD search task permission to ad read access #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardik-k-shah
previously approved these changes
Jan 28, 2021
saratvemulapalli
previously approved these changes
Jan 28, 2021
|
@ylwu-amzn Could you please check why CI/Test is failing? |
|
Please rebase against master to rerun CI. There was a flaky test unable to bind to a port on Github CI host. |
Thanks a lot. Will do this. |
ylwu-amzn
dismissed stale reviews from saratvemulapalli and hardik-k-shah
via
f8a6b95
Codecov Report
@@ Coverage Diff @@
## master #997 +/- ##
============================================
+ Coverage 64.44% 64.50% +0.05%
Complexity 3225 3225
============================================
Files 244 244
Lines 17174 17174
Branches 3043 3043
============================================
+ Hits 11068 11078 +10
+ Misses 4565 4555 -10
Partials 1541 1541
Continue to review full report at Codecov.
|
|
@sujithvm Now the CI workflow passed. Can you help review and approve? |
saratvemulapalli
approved these changes
Feb 1, 2021
hardik-k-shah
approved these changes
Feb 1, 2021
chrousto
referenced
this pull request
in chrousto/security
Mar 6, 2021
lbreinig
pushed a commit
to lbreinig/security
that referenced
this pull request
Dec 23, 2021
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opendistro-for-elasticsearch/security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly
Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Maintenance
Github Issue # or road-map entry, if available:
N/A
Description of changes:
Add new AD search task action to AD read access
Why these changes are required?
Search AD task action should be part of AD read access.
What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
We add new API to search AD task.
Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
No change to actual source. No additional testing needed.
TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
N/A
Is it backport from master branch? (If yes, please add backport PR # and commits #)
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.