Make driver throw SQLSTATE 28000 for invalid username or password #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey and
acarbonetto
as code owners
* Made driver throw SQLSTATE 28000 for invalid username or password Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Made SQLSTATE string a constant and added a separate catch block for HTTPException Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Changed constant name to follow naming convention Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added 08001 SQLSTATE to catch connection errors Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Reverted 08001 change Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
GumpacG
force-pushed
the
integ-auth-sqlstate
branch
from
1369d12 to
1d1c491
Compare
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
MitchellGale
approved these changes
Jun 29, 2023
acarbonetto
approved these changes
Jun 29, 2023
Yury-Fridlyand
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change throws SQLSTATE 28000 for invalid username or password which is required by Tableau. This only covers 401 responses, responses like 403 from SIGV4 returns a different message.
Before:
After:
Issues Resolved
#95
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.