Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for date type in the TACO (#5) #91

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Jun 14, 2023

Description

The manifest file change allows for Tableau to use time columns without having to cast.
The dialect file changes fixes and supports the following test files and test cases:

TestPath Test Case
/opt/homebrew/lib/python3.11/site-packages/tdvt/logicaltests/setup/calcs/setup.Filter.Date_In.simple_lower.xml  
/opt/homebrew/lib/python3.11/site-packages/tdvt/logicaltests/setup/calcs/setup.Filter.Date_In_Time.simple_lower.xml  
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.calcs_data.time.txt time1
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.math.date_minus_date.txt [date2] - [date2]
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.operator.date.equality.txt date0 == 7/4/1972
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.operator.date.gt.txt date0 > 11/12/1975
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.operator.date.gte.txt date0 >= 11/12/1975
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.operator.date.lt.txt date0 < 11/12/1975
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.operator.date.lte.txt date0 <= 11/12/1975
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.operator.date.minus_datetime.txt date0 - datetime0
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.operator.date.not_equal.txt date0 != 11/12/1975
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.max.txt MAX([date2], [date3])
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.min.txt MIN([date2], [date3])
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.B639952.txt SUM([date0]-1-[date1])
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.B639952.txt SUM([date0]+300-[date1])
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.B639952.txt [date0]-([date1]-1-[date2])
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.B639952.txt [date1]-([date3]+500-[date2])
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.B639952.txt [date1]-([date3]+500-[date2])+([date3]-[date0])
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.B639952.txt SUM(([date3]-400-[date0])+([date3]+500-[date2]))
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.B639952.txt SUM([date3]-1-(date(dateadd('month', 3, 2004-04-15 )))+1)
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.math.txt [date2] =  [date2]
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.math.txt [date2] >  [date2]
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.math.txt [date2] >= [date2]
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.math.txt [date2] <  [date2]
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.math.txt [date2] <= [date2]
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.date.math.txt [date2] <> [date2]
/opt/homebrew/lib/python3.11/site-packages/tdvt/exprtests/standard/setup.logical.txt min(date0,date1)

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Added fixes for some date/time functions

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

* Added functions for date agg and operations

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

---------

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG GumpacG merged commit e42aa0d into opensearch-project:main Jun 14, 2023
Yury-Fridlyand added a commit to Bit-Quill/sql-jdbc that referenced this pull request Jun 15, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@GumpacG GumpacG deleted the integ-taco-update branch June 27, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants