Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] [PPL] Add support to reserved keywords in PPL #1318

Closed
mengweieric opened this issue Feb 2, 2023 · 3 comments
Closed

[FEATURE] [PPL] Add support to reserved keywords in PPL #1318

mengweieric opened this issue Feb 2, 2023 · 3 comments
Labels
enhancement New feature or request PPL Piped processing language v2.6.0

Comments

@mengweieric
Copy link
Collaborator

Is your feature request related to a problem?
Currently for PPL query, the backtick `` has to be added to surround a reserved keyword in order for query engine to understand. Request to add reserved keyword support.

What solution would you like?
Query contains reserved keys do not need backtick just like any other non-reserved keywords

Do you have any additional context?
Example:

source = sample-data | stats count() by `index` --> index is reserved key and has to be surrounded with backtick to work

// Ideally just 

source = sample-data | stats count() by index
@mengweieric mengweieric added enhancement New feature or request untriaged labels Feb 2, 2023
@Yury-Fridlyand
Copy link
Collaborator

Related to #672, #712 and similar issues. keywordsCanBeId list should be extended in grammar files.

@anirudha
Copy link
Collaborator

anirudha commented Feb 2, 2023

whats constitues a reserved keyword? how do we define what is reserved

@penghuo penghuo removed the untriaged label Feb 3, 2023
@dai-chen dai-chen added PPL Piped processing language v2.6.0 labels Feb 3, 2023
@penghuo
Copy link
Collaborator

penghuo commented Feb 6, 2023

backport to 2.5. #1324

@penghuo penghuo closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PPL Piped processing language v2.6.0
Projects
None yet
Development

No branches or pull requests

5 participants