Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more keywords as identifier in PPL #1319

Merged
merged 5 commits into from
Feb 3, 2023

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Feb 3, 2023

Signed-off-by: Peng Huo penghuo@gmail.com

Solve #1318

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo changed the title PPL support keywords as identifier Add more keywords as identifier in PPL Feb 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #1319 (feaa8fa) into main (513428b) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1319   +/-   ##
=========================================
  Coverage     98.36%   98.36%           
  Complexity     3640     3640           
=========================================
  Files           343      343           
  Lines          9016     9016           
  Branches        585      585           
=========================================
  Hits           8869     8869           
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Yury-Fridlyand
Copy link
Collaborator

Can you copy-paste this for SQL?

@penghuo
Copy link
Collaborator Author

penghuo commented Feb 3, 2023

Can you copy-paste this for SQL?

This is quick fix for PPL which is required by Observability.
#1191 already cover SQL releated identifier change.

@penghuo penghuo marked this pull request as ready for review February 3, 2023 17:42
@penghuo penghuo requested a review from a team as a code owner February 3, 2023 17:42
@penghuo penghuo self-assigned this Feb 3, 2023
@dai-chen dai-chen added the enhancement New feature or request label Feb 3, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@penghuo penghuo merged commit 79c7922 into opensearch-project:main Feb 3, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 3, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 79c7922)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 3, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 79c7922)
penghuo added a commit that referenced this pull request Feb 4, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 79c7922)

Co-authored-by: Peng Huo <penghuo@gmail.com>
penghuo added a commit that referenced this pull request Feb 4, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 79c7922)

Co-authored-by: Peng Huo <penghuo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants