Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Refactor OpenSearchQueryRequest and OpenSearchScrollRequest so that we pass in includes list from query #1536

Closed
acarbonetto opened this issue Apr 17, 2023 · 0 comments · Fixed by #1937
Closed

[Enhancement] Refactor OpenSearchQueryRequest and OpenSearchScrollRequest so that we pass in includes list from query #1536

acarbonetto opened this issue Apr 17, 2023 · 0 comments · Fixed by #1937
Assignees
@acarbonetto
Labels
maintenance Improves code quality, but not the product

Comments

@acarbonetto
Copy link
Collaborator

Is your feature request related to a problem?

When creating the OpenSearchResponse, we don't have access to the OpenSearchQueryRequest or OpenSearchScrollRequest - which is needed for context. Right now, we are picking out the includes list but this is unavailable for scroll requests (which means _id and other metafields are not output on 2+ pages of pagination requests).

What solution would you like?

  1. a way to serialize the includes list that is send to OpenSearch in the request.
  2. a way to pass the serialized includes list to the OpenSearchResponse so that we aren't sending unnecessary information around.
  3. Maybe refactor OpenSearchQueryRequest or OpenSearchScrollRequest to handle/pass this information for both paged and non-paged requests.

What alternatives have you considered?
Related to changes in #1456

Do you have any additional context?
N/A
@acarbonetto acarbonetto added enhancement New feature or request untriaged labels Apr 17, 2023
@dai-chen dai-chen added maintenance Improves code quality, but not the product and removed enhancement New feature or request untriaged labels Apr 17, 2023
acarbonetto added a commit to Bit-Quill/opensearch-project-sql that referenced this issue Aug 2, 2023
@acarbonetto
opensearch-project#1536: Refactor OpenSearchQueryRequest and move inc…
3b7b3bd 
…ldues to builder

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
This was referenced Aug 2, 2023
Closed
Merged
acarbonetto added a commit to Bit-Quill/opensearch-project-sql that referenced this issue Aug 3, 2023
@acarbonetto
opensearch-project#1536: Checkstyle fixes
bc43670 
Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
acarbonetto added a commit to Bit-Quill/opensearch-project-sql that referenced this issue Aug 3, 2023
@acarbonetto
opensearch-project#1536: Checkstyle fixes
00b25b7 
Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
@acarbonetto acarbonetto self-assigned this Aug 3, 2023
acarbonetto added a commit to Bit-Quill/opensearch-project-sql that referenced this issue Aug 4, 2023
@acarbonetto
opensearch-project#1536: Refactor OpenSearchQueryRequest and move inc…
41944d4 
…ludes to builder (#320)

* opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* opensearch-project#1536: Checkstyle fixes

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* opensearch-project#1536: Checkstyle fixes

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

---------

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
@acarbonetto acarbonetto mentioned this issue Aug 4, 2023
Merged
6 tasks
acarbonetto added a commit to Bit-Quill/opensearch-project-sql that referenced this issue Aug 4, 2023
@acarbonetto
opensearch-project#1536: Refactor OpenSearchQueryRequest and move inc…
33d0991 
…ludes to builder (#320)

* opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* opensearch-project#1536: Checkstyle fixes

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* opensearch-project#1536: Checkstyle fixes

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

---------

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand linked a pull request Aug 5, 2023 that will close this issue
(#1536) Refactor OpenSearchQueryRequest and move includes to builder #1937
Merged
6 tasks
acarbonetto added a commit to Bit-Quill/opensearch-project-sql that referenced this issue Aug 9, 2023
@acarbonetto
opensearch-project#1536: Spotless Apply
b39824b 
Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Yury-Fridlyand pushed a commit that referenced this issue Aug 9, 2023
@acarbonetto
(#1536) Refactor OpenSearchQueryRequest and move includes to builder (#…
7d23e0f 
…1937)

* #1536: Refactor OpenSearchQueryRequest and move includes to builder (#320)

* #1536: Refactor OpenSearchQueryRequest and move incldues to builder

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* #1536: Checkstyle fixes

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* #1536: Checkstyle fixes

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

---------

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* #1536: Spotless Apply

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

---------

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Aug 9, 2023
@github-actions
(#1536) Refactor OpenSearchQueryRequest and move includes to builder (#…
48928d9 
…1937)

* #1536: Refactor OpenSearchQueryRequest and move includes to builder (#320)

* #1536: Refactor OpenSearchQueryRequest and move incldues to builder

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* #1536: Checkstyle fixes

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* #1536: Checkstyle fixes

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

---------

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* #1536: Spotless Apply

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

---------

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
(cherry picked from commit 7d23e0f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
GumpacG pushed a commit that referenced this issue Aug 10, 2023
@opensearch-trigger-bot @github-actions
(#1536) Refactor OpenSearchQueryRequest and move includes to builder (#…
b480916 
…1937) (#1948)

* #1536: Refactor OpenSearchQueryRequest and move includes to builder (#320)

* #1536: Refactor OpenSearchQueryRequest and move incldues to builder



* #1536: Checkstyle fixes



* #1536: Checkstyle fixes



---------



* #1536: Spotless Apply



---------


(cherry picked from commit 7d23e0f)

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this issue Aug 14, 2023
@acarbonetto @MitchellGale
(opensearch-project#1536) Refactor OpenSearchQueryRequest and move in…
bb9011f 
…cludes to builder (opensearch-project#1937)

* opensearch-project#1536: Refactor OpenSearchQueryRequest and move includes to builder (#320)

* opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* opensearch-project#1536: Checkstyle fixes

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* opensearch-project#1536: Checkstyle fixes

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

---------

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

* opensearch-project#1536: Spotless Apply

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>

---------

Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acarbonetto acarbonetto

Labels
maintenance Improves code quality, but not the product
Projects
None yet
Milestone
No milestone
2 participants
@dai-chen @acarbonetto