Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OpenSearch-Dashboard workflow can only succeed in project repo #641

Closed
MaxKsyunz opened this issue Jun 17, 2022 · 1 comment
Closed
Labels
bug Something isn't working infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@MaxKsyunz
Copy link
Collaborator

What is the bug?
When sql-workbench-test-and-build-workflow.yml runs, it checks out opensearch-project/opensearch-dashboards repository.
However, it does so into a folder that is specific to this repo.

How can one reproduce the bug?

  1. Fork opensearch-project/sql
  2. Run sql-workbench-test-and-build-workflow.yml workflow
    -> The workflow will fail.

See here for a complete example.

What is the expected behavior?
The workflow passes.

Do you have any additional context?
When GitHub Action runs, it creates a pipeline directory and a workspace directory.

Pipeline directory is /home/runner/work/$REPO_NAME and workspace directory is /home/runner/work/$REPO_NAME/$REPO_NAME.

actions/checkout runs out of the pipeline directory, but action/setup-node runs out of the workspace directory.

OpenSearch-Dashboards is checked out into /home/runner/work/$REPO_NAME/sql/OpenSearch-Dashboards and

setup-node action attempts to read a file in /home/runner/work/$REPO_NAME/$REPO_NAME/OpenSearch-Dashboards directory.

=> it will only succeed when $REPO_NAME is sql.

@MaxKsyunz MaxKsyunz added bug Something isn't working untriaged labels Jun 17, 2022
@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Aug 30, 2022
@MaxKsyunz
Copy link
Collaborator Author

Fixed by #704

@MaxKsyunz MaxKsyunz moved this to Done in SQL Engineering Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants